# VNX-1284: Improper Validation of Specified Quantity in Input

A quantity the client chose (a request field named quantity, qty, amount, units, credits, points, coins, num_items.

| Field | Value |
|---|---|
| Rule ID | `VNX-1284` |
| Severity | Medium |
| SARIF level | `warning` |
| Kind | `sast` |
| Languages | JavaScript / TypeScript, Python |
| CWE | [CWE-1284](https://cwe.mitre.org/data/definitions/1284.html) |
| CAPEC | [CAPEC-66](https://capec.mitre.org/data/definitions/66.html) |
| ATT&CK | [T1190](https://attack.mitre.org/techniques/T1190/) |
| CWSS vector | `CWSS:1.0/TI:M/AP:RU/AL:S/IC:N/FC:LT/RP:RU/RL:S/AV:L/AS:N/IN:A/SC:A/BI:M/DI:H/EX:M/EC:N/P:C` |
| Tags | `improper-validation-of-specified-quantity` `business-logic` `cwe-1284` |
| Source | [`internal/sast/rules/vnx-1284.rego`](https://github.com/Vulnesis/cli/blob/main/internal/sast/rules/vnx-1284.rego) |

## Overview

VNX-1284 maps to [CWE-1284: Improper Validation of Specified Quantity in Input](https://cwe.mitre.org/data/definitions/1284.html).

## Why this matters

A quantity or amount taken from the request and used as is lets the client choose a negative or huge value. A negative transfer moves money the wrong way, a negative cart quantity gives a refund, and a huge one overflows a total or exhausts stock.

## What gets flagged

```python
product.stock += int(request.form["quantity"])

qty = int(request.POST.get("quantity", 1))
total = product.price * qty
```

```javascript
const { productId, quantity } = req.body;
await CartItem.create({ productId, quantity });

const { points } = req.body;
await Member.updateOne({ _id: id }, { $inc: { points: -points } });
```

Not flagged: a value compared (`if amount <= 0 or amount > src.balance: abort(400)`) or clamped (`max(1, ...)`) before use, a file that validates with a schema (`Joi.number().positive()`, pydantic `conint(gt=0)`), a value that is only displayed.

A client amount credited to a balance or booked as an order total (`dst.balance += int(request.form["amount"])`, `account.balance -= amount`, `{ $inc: { balance: -amount } }` in a wallet or payment handler) is reported by [VNX-840](/sast/rules/vnx-840.md) (Client-Controlled Monetary Value), not here as well: the negative or oversized amount is how that one defect is exploited, so it is one finding. Quantities, units, credits, points and stock, and money values VNX-840 does not take, stay here.

## Remediation

1. Reject quantities below the minimum (usually 1) and above a business maximum before using them.
2. Validate request bodies with a schema that states the range.

## References

- [CWE-1284: Improper Validation of Specified Quantity in Input](https://cwe.mitre.org/data/definitions/1284.html)

## Suppressing this rule

Put a `nosec` comment on the line, or on line 1 to cover the whole file. Use the comment marker of the file's language (`#`, `//`, `--` or `;`):

```text
# nosec vnx-1284
// nosec vnx-1284
```

Or record an ignore rule: `vulnetix ignore add --rule vnx-1284 --reason "..."`. See [Suppressing findings](/sast/guides/suppressing-findings.md).
