# VNX-488: Exposure of Data Element to Wrong Session

Per-request or per-user data stored in a field of a Java component that one instance serves every request.

| Field | Value |
|---|---|
| Rule ID | `VNX-488` |
| Severity | Low |
| SARIF level | `note` |
| Kind | `sast` |
| Languages | Java |
| CWE | [CWE-488](https://cwe.mitre.org/data/definitions/488.html) |
| CAPEC | [CAPEC-66](https://capec.mitre.org/data/definitions/66.html) |
| ATT&CK | [T1190](https://attack.mitre.org/techniques/T1190/) |
| CWSS vector | `CWSS:1.0/TI:L/AP:RU/AL:S/IC:N/FC:LT/RP:RU/RL:S/AV:L/AS:N/IN:A/SC:A/BI:L/DI:H/EX:L/EC:N/P:L` |
| Tags | `servlet` `shared-state` `session` `race-condition` `cwe-488` |
| Source | [`internal/sast/rules/vnx-488.rego`](https://github.com/Vulnesis/cli/blob/main/internal/sast/rules/vnx-488.rego) |

## Overview

VNX-488 maps to [CWE-488: Exposure of Data Element to Wrong Session](https://cwe.mitre.org/data/definitions/488.html). It reports request data written into a field of a servlet or Spring controller, which one instance shares across all requests.

## Why this matters

The container creates one servlet instance, and Spring creates one controller instance, and every request thread runs through it at once. A field set from request A can be read while serving request B, so one user sees another user's name, account or cart.

## What gets flagged

```java
public class ProfileServlet extends HttpServlet {
    private String userName;

    protected void doGet(HttpServletRequest request, HttpServletResponse response) {
        userName = request.getParameter("user");     // FLAGGED
        response.getWriter().println(render(userName));
    }
}
```

```java
@RestController
public class CartController {
    private static String lastUser;

    @GetMapping("/cart")
    public Cart cart(HttpServletRequest req) {
        String user = req.getRemoteUser();
        lastUser = user;                              // FLAGGED
        ...
```

Not flagged: the same value kept in a local variable, a `final` field, or a field set in `init()` from servlet configuration.

## Remediation

1. Keep per-request data in local variables or pass it as method arguments.
2. Store per-user data in the request (`request.setAttribute`) or the session, never in a field of the servlet or controller.
3. If a component must hold per-request state, make it request-scoped (`@RequestScope`) rather than a singleton.

## References

- [CWE-488: Exposure of Data Element to Wrong Session](https://cwe.mitre.org/data/definitions/488.html)

## Suppressing this rule

Put a `nosec` comment on the line, or on line 1 to cover the whole file. Use the comment marker of the file's language (`#`, `//`, `--` or `;`):

```text
# nosec vnx-488
// nosec vnx-488
```

Or record an ignore rule: `vulnetix ignore add --rule vnx-488 --reason "..."`. See [Suppressing findings](/sast/guides/suppressing-findings.md).
